Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Fix error with lock_factory in login_throttling #51359

Conversation

BaptisteContreras
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51347
License MIT
Doc PR

Remove incorrect check for Lock configuration in Security Bundle which leads to an exception when using lock_factory of the login_throttling (as explained in #51347)

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@BaptisteContreras BaptisteContreras force-pushed the error-with-lockfactory-in-loginthrottling branch from 30b1269 to a22e891 Compare August 11, 2023 15:23
@BaptisteContreras
Copy link
Contributor Author

I don't really understand why these tests failed. It seems unrelated to my changes...
If someone can enlighten me !

@wouterj
Copy link
Member

wouterj commented Aug 12, 2023

I don't really understand why these tests failed. It seems unrelated to my changes...
If someone can enlighten me !

Indeed. Tests on the branches are often broken (due to transient tests or changes in the ecosystem). These are unrelated to the changes you've made, so we can ignore them in this PR.

@fabpot
Copy link
Member

fabpot commented Aug 12, 2023

Thank you @BaptisteContreras.

@fabpot fabpot merged commit a0c1de1 into symfony:6.3 Aug 12, 2023
7 of 9 checks passed
@fabpot fabpot mentioned this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants