[DoctrineBridge] Add message to #[MapEntity] for NotFoundHttpException
#51562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, it won't. This message would be purely for development. I'm not saying, we shouldn't merge it, but I'm curious about the motivation behind this change. |
|
I am exposing message in NotFoundHttpException to the user for a friendly 404 message in my project. This is inspired by the parameter in |
nicolas-grekas
approved these changes
Nov 20, 2023
fabpot
approved these changes
Feb 2, 2024
|
Thank you @moesoha. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the message in NotFoundHttpException to be overridden with the
messageargument in#[MapEntity].