[ErrorHandler] Handle PHP 8.3 highlight_file function output changes

[PhilETaylor]

Q	A
Branch?	5.4
Bug fix?	PHP 8.3 Compatibility
New feature?	no
Deprecations?	no
License	MIT

PHP 8.3 changes the output from the highlight_file function as described here: https://php.watch/versions/8.3/highlight_file-highlight_string-html-changes

I accidentally ran into this head first when using PHP 8.3.0-RC1 in development with Symfony 6.4-dev when my error had no code rendered

Also affected the {{ '/path/to/file.html.twig'|file_excerpt(140,5) }} twig code file_except renderer - easier to replicate with that code just throw it into your twig file with a valid /path/to/file.html.twig - before this PR there would be no output, after this PR the file except would be shown.

Same fix applied to both files.

After this fix the code rendered returned.

[derrabus]

Thank you. Does this affect 5.4 or 6.3 as well? If that's the case, please retarget your PR.

[PhilETaylor]

looks like it needs to be 5.4.

symfony/src/Symfony/Component/ErrorHandler/ErrorRenderer/HtmlErrorRenderer.php

Line 271 in fcb754a

$code = @highlight_file($file, true);

[PhilETaylor]

its late and my eyes sleepy, but I think Ive downgraded it ok, and removed short function syntax in my original to be compatible with PHP 7 also. Should be ok to test now.

[javiereguiluz]

It's very important to update Symfony for this BC-break in PHP 8.3. Thanks Phil for taking care of this!

[nicolas-grekas]

Thank you @PhilETaylor.