[TwigBridge][TwigBundle] Drop support for Twig 2 #51626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
added
TwigBundle
RFC
carsonbot
changed the title
fabpot
approved these changes
Sep 11, 2023
GromNaN
approved these changes
Sep 11, 2023
stof
reviewed
Sep 11, 2023
GromNaN
reviewed
Sep 11, 2023
derrabus
force-pushed
the
drop/twig-2
branch
from
7a50b62
to
2746e9a
Compare
Done for TwigBundle and TwigBridge. Not sure if I need to do that for the other bundles/components as well. |
|
@derrabus I think it is OK as is. |
stof
reviewed
Sep 11, 2023
| @@ -25,7 +25,7 @@ | |||
| "symfony/http-kernel": "^6.4|^7.0", | |||
| "symfony/process": "^6.4|^7.0", | |||
| "symfony/uid": "^6.4|^7.0", | |||
| "twig/twig": "^2.13|^3.0.4" | |||
| "twig/twig": "^3.0.4" | |||
There was a problem hiding this comment.
should this add the conflict rule ?
There was a problem hiding this comment.
Not sure. It didn't have one before and I don't know why that is.
There was a problem hiding this comment.
The code that depends on twig is very robust.
stof
approved these changes
Sep 11, 2023
|
Thank you @derrabus. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make our lives easier and only support one major version of Twig in the future. Upgrading projects from Twig 2 to 3 shouldn't be much trouble anyway.