[Security] Make impersonation_path() argument mandatory and add impersonation_url()
#51804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also add |
…personation_url()`
alexandre-daubois
force-pushed
the
fix-impersonation-path
branch
from
3ed6fbd
to
5d71d95
Compare
alexandre-daubois
changed the title
impersonation_path() argument mandatoryimpersonation_path() argument mandatory and add impersonation_url()
|
I think that's a good idea, I added the new function |
stof
approved these changes
Oct 2, 2023
fabpot
approved these changes
Oct 2, 2023
|
Thank you @alexandre-daubois. |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Oct 4, 2023
…ation path (alexandre-daubois) This PR was merged into the 6.4 branch. Discussion ---------- Add new Twig bridge function to generate impersonation path Fix - symfony#18960 Fix - symfony#18968 However, I think we should wait for this PR to be merged (or not), because it seems the current implementation has a problem: - symfony/symfony#51804 ~This doc PR takes into account my fix PR above.~ Merged 👍 Commits ------- 061bc3f [TwigBridge] Add new Twig bridge function to generate impersonation path
|
Thank you for cleaning up my mess! Appreciate it. |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #50030
When documenting this function, I found out that the
identifierargument was optional, which seemed weird to me given the function purpose.I then had a look at the implementation, and I saw that
ImpersonateUrlGenerator::generateImpersonationPath()accepts a nullable string. However, the underlying call toImpersonateUrlGenerator::buildPath()doesn't accept a nullable string. I propose to make theidentifierargument mandatory, which makes more sense here.I also added the missing Changelog line and
impersonation_url()