[Serializer] Fix using DateIntervalNormalizer with union types

[Jeroeny]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

The union logic of AbstractObjectNormalizer tries to denormalize each union type and catches NotNormalizableValueException (among some other exceptions). If a non-catching exception is thrown, denormalization fails on that first type, while a later type might have succeeded.

If I try to denormalize a DateTimeInterface value into a DateInterval|DateTimeInterface type, it will fail because the DateIntervalNormalizer throws UnexpectedValueException instead of NotNormalizableValueException.
Denormalizing a DateInterval into DateTimeInterface|DateInterval does work, because DateTimeNormalizer throws NotNormalizableValueException. I also checked some other Object-specific normalizers like Uid, Problem, DateTimeZone, DataUri, BackedEnum, they are using NotNormalizableValueException.

See reproducer: https://github.com/Jeroeny/reproduce/tree/union/src

[nicolas-grekas]

Could it be possible to add a test case that covers the situation you describe, ie that uses a union type?

[Jeroeny]

@nicolas-grekas I think this tests the union type with a failure first: https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/Serializer/Tests/SerializerTest.php#L740

But it won't test every normalizer for throwing the correct exception.

And secondly the DateIntervalNormalizerTest now does assert the exception is thrown for this normalizer.

[nicolas-grekas]

/cc @HypeMC maybe for a review? 🙏

[HypeMC]

@nicolas-grekas Sure, I'll take a look sometime today.

[HypeMC]

Looks good, tried it out and it works as expected.

[fabpot]

Thank you @Jeroeny.