[Notifier] [Telegram] Fix version and exception signature

[OskarStark]

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	--
License	MIT

The PR

• [Notifier] [Telegram] Extend options for location, document, audio, video, venue, photo, animation, sticker & contact #51717

introduced a new exception in the Notifier component. I tested this locally and faced the following error:

Class "Symfony\Component\Notifier\Exception\MultipleExclusiveOptionsUsedException" not found

The version bump of the notifier was missing.
I also added tests for the exception class.

I am wondering about the parameter signature, and I am not sure if the second parameter should be nullable:

symfony/src/Symfony/Component/Notifier/Exception/MultipleExclusiveOptionsUsedException.php

Lines 17 to 31 in c868be4

	class MultipleExclusiveOptionsUsedException extends InvalidArgumentException
	{
	/**
	* @param string[] $usedExclusiveOptions
	* @param string[]|null $exclusiveOptions
	*/
	public function __construct(array $usedExclusiveOptions, array $exclusiveOptions = null, \Throwable $previous = null)
	{
	$message = sprintf('Multiple exclusive options have been used "%s".', implode('", "', $usedExclusiveOptions));
	if (null !== $exclusiveOptions) {
	$message .= sprintf(' Only one of %s can be used.', implode('", "', $exclusiveOptions));
	}
	parent::__construct($message, 0, $previous);
	}

@igrizzli is there anything I am missing or can e adjust the signature:

- public function __construct(array $usedExclusiveOptions, array $exclusiveOptions = null, \Throwable $previous = null)
+ public function __construct(array $usedExclusiveOptions, array $exclusiveOptions, \Throwable $previous = null)
``

[igrizzli]

Good catch, thank you.

[OskarStark]

Ready to merge from my side

[stof]

The telegram tests are failing on CI with an error about an undefined key. Is it coming from that PR as well ?

[OskarStark]

The telegram tests are failing on CI with an error about an undefined key. Is it coming from that PR as well ?

I will check later

[OskarStark]

I cannot reproduce the missing key, I tried to composer update --prefer-lowest, but tests are still passing 🤔

Besides that, I think we should not write json and decode it, but write an array and encode it in the assertion. But that should be a floor up PR once green

[OskarStark]

@igrizzli any idea?

[OskarStark]

As far as @xabbuh and I can find out so far, dropping symfony/http-client:^5.4 helps, so now we have the same errors in high and low deps test.

For the errors itself, maybe

• [HttpClient] Support file uploads by nesting resource streams in body option #49911

is related....

[nicolas-grekas]

LGTM thanks, just minor details

[nicolas-grekas]

why this bump?

[xabbuh]

we need #49911

[OskarStark]

and for this we need symfony/mime also

[OskarStark]

Thanks @xabbuh, looks like symfony/mime was missing

[nicolas-grekas]

I'm removing final : a test case is not an API, we don't need extra visual debt (same as void) ;)

[nicolas-grekas]

Thank you @OskarStark.