Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Allow custom meta location in ResourceCheckerConfigCache #52043

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Oct 13, 2023

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT

This makes it possible to put the meta file in a different location.

One use case can be to write a file to src while keeping the meta file in var.

@ruudk
Copy link
Contributor Author

ruudk commented Oct 13, 2023

CI failures are unrelated to this PR.

@ruudk ruudk requested a review from OskarStark October 14, 2023 11:50
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
@ruudk ruudk force-pushed the ResourceCheckerConfigCache branch 2 times, most recently from 74a956f to 505b24a Compare November 16, 2023 09:41
@ruudk
Copy link
Contributor Author

ruudk commented Nov 16, 2023

@OskarStark Rebased on 7.1, it's ready for review. Failures are unrelated to this pr.

This makes it possible to put the meta file in a different location.

One use case can be to write a file to `src` while keeping the meta file in `var`.
@fabpot
Copy link
Member

fabpot commented Feb 3, 2024

Thank you @ruudk.

@fabpot fabpot merged commit 29632fd into symfony:7.1 Feb 3, 2024
3 of 9 checks passed
@ruudk ruudk deleted the ResourceCheckerConfigCache branch February 5, 2024 09:15
nicolas-grekas added a commit that referenced this pull request Feb 9, 2024
…alamirault)

This PR was squashed before being merged into the 7.1 branch.

Discussion
----------

[Config] Allow custom meta location in `ConfigCache`

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT

#52043 allow to configure meta location in `ResourceCheckerConfigCache`
`ConfigCache` extends this file.

This PR allow to configure meta location in `ConfigCache`

Commits
-------

eacb74c [Config] Allow custom meta location in `ConfigCache`
@fabpot fabpot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants