Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Expose meta on ResourceCheckerConfigCache and ConfigCacheInterface #52059

Open
wants to merge 1 commit into
base: 7.2
Choose a base branch
from

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Oct 14, 2023

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT

When a developer adds meta to a config cache, it should also be possible to get back the meta.

I use these config caches for my own framework and want to retrieve a specific meta associated to the cache.

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 f".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 6.4 milestone Oct 14, 2023
@ruudk ruudk changed the title Expose meta on ResourceCheckerConfigCache / ConfigCacheInterface [Config] Expose meta on ResourceCheckerConfigCache / ConfigCacheInterface Oct 14, 2023
@carsonbot carsonbot changed the title [Config] Expose meta on ResourceCheckerConfigCache / ConfigCacheInterface Expose meta on ResourceCheckerConfigCache / ConfigCacheInterface Oct 14, 2023
@ruudk ruudk changed the title Expose meta on ResourceCheckerConfigCache / ConfigCacheInterface [Config] Expose meta on ResourceCheckerConfigCache and ConfigCacheInterface Oct 14, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 7.1 Nov 15, 2023
When a developer adds meta to a config cache, it should also be possible to get back the meta.

I use these config caches for my own framework and want to retrieve a specific meta associated to
the cache.
@ruudk
Copy link
Contributor Author

ruudk commented Nov 16, 2023

Rebased on 7.1, it's ready for review. Failures are unrelated to this pr.

@xabbuh xabbuh modified the milestones: 7.1, 7.2 May 15, 2024
@xabbuh xabbuh added the Config label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants