[FrameworkBundle] Fix CommandDataCollector is always registered #52229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Oct 21, 2023
src/Symfony/Bundle/FrameworkBundle/Resources/config/console_debug.php
Outdated
Show resolved
Hide resolved
chalasr
approved these changes
Oct 21, 2023
chalasr
force-pushed
the
fix/console-profiler
branch
from
3e1b08d
to
6e2c2ec
Compare
|
Thanks @smnandre |
stof
reviewed
Oct 24, 2023
| @@ -922,7 +923,7 @@ private function registerProfilerConfiguration(array $config, ContainerBuilder $ | |||
| $container->removeDefinition('console_profiler_listener'); | |||
| } | |||
|
|
|||
| if (!class_exists(CommandDataCollector::class)) { | |||
| if (!$container->getParameter('kernel.debug') || !class_exists(CliRequest::class) || !class_exists(CommandDataCollector::class)) { | |||
There was a problem hiding this comment.
why this check for kernel.debug ? If you enable the profiler in non-debug mode (for instance in tests), you will need this.
There was a problem hiding this comment.
Good question, i’ll digg tomorrow
There was a problem hiding this comment.
This line will also be reverted in #52274.
There was a problem hiding this comment.
Let's continue discussion (or stop it) on #52274 then
There was a problem hiding this comment.
Found it: it was because then (non-debug mode), there is something not working, but this is not directly related to the composer conflit, and i'll open a dedicated issue.
This was referenced Oct 29, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at fixing #52210, allowing to revert #52218 and leave the conflict constraints untouched
CommandDataCollector was always registered, and not always removed from the container when not needed/invalid.