Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Added missing translations for Czech (cs) #52239

Merged
merged 1 commit into from Nov 20, 2023

Conversation

shubhalgupta
Copy link
Contributor

@shubhalgupta shubhalgupta commented Oct 22, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #51936
License MIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "5.4" but it seems your PR description refers to branch "6.4 for features / 5.4 or 6.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@shubhalgupta
Copy link
Contributor Author

@carsonbot now please review!

@Nyholm
Copy link
Member

Nyholm commented Oct 23, 2023

Hey.

Thank you for this PR. Are you a native Czech speaker?
I tried my best to verify this with Google translate and it looks okey.

Do you know a native that could verify this?

@shubhalgupta
Copy link
Contributor Author

shubhalgupta commented Oct 23, 2023 via email

@shubhalgupta
Copy link
Contributor Author

@Nyholm please do merge this!

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. =)

I'll be happy to approve this. A second maintain will review and merge this if they like this as much as I do.

Thank you for your work!

@shubhalgupta
Copy link
Contributor Author

@Nyholm who is the second maintainer?

@shubhalgupta
Copy link
Contributor Author

And thanks for your approval @Nyholm

@Nyholm
Copy link
Member

Nyholm commented Oct 23, 2023

@Nyholm who is the second maintainer?

There are a few of us. See https://symfony.com/doc/current/contributing/code/core_team.html
Im sure someone will look at this in the next 2-3 days.

@shubhalgupta
Copy link
Contributor Author

@fabpot, @nicolas-grekas kindly review this!

@stof stof changed the title Closes #51936-Added Missing translations for Czech (cs) in validators… Added Missing translations for Czech (cs) in validator.cs.xlf Oct 23, 2023
@shubhalgupta
Copy link
Contributor Author

@stof can you merge this, please!

@shubhalgupta
Copy link
Contributor Author

@Nyholm can you please get it merged?

@carsonbot carsonbot changed the title Added Missing translations for Czech (cs) in validator.cs.xlf [Validator] Added Missing translations for Czech (cs) in validator.cs.xlf Oct 24, 2023
@OskarStark OskarStark changed the title [Validator] Added Missing translations for Czech (cs) in validator.cs.xlf Added Missing translations for Czech (cs) Oct 24, 2023
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation, thanks

@carsonbot carsonbot changed the title Added Missing translations for Czech (cs) [Validator] Added Missing translations for Czech (cs) Oct 24, 2023
@shubhalgupta
Copy link
Contributor Author

@OskarStark now kindly check!

@xabbuh
Copy link
Member

xabbuh commented Oct 24, 2023

I have asked a Czech colleague to review the changes

Copy link

@jan-simbera jan-simbera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there are some changes in the wording of the Validation Error Messages, which should be implemented to be correct in Czech.

@jan-simbera
Copy link

jan-simbera commented Oct 24, 2023 via email

@OskarStark OskarStark changed the title [Validator] Added Missing translations for Czech (cs) [Validator] Added missing translations for Czech (cs) Oct 30, 2023
@nicolas-grekas
Copy link
Member

Thank you @shubhalgupta.

@nicolas-grekas nicolas-grekas merged commit b5376c7 into symfony:5.4 Nov 20, 2023
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants