New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Validator] Added missing translations for Czech (cs) #52239
Conversation
shubhalgupta
commented
Oct 22, 2023
•
edited by OskarStark
edited by OskarStark
Q | A |
---|---|
Branch? | 5.4 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Issues | Fix #51936 |
License | MIT |
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Hey! Thanks for your PR. You are targeting branch "5.4" but it seems your PR description refers to branch "6.4 for features / 5.4 or 6.3 for bug fixes". Cheers! Carsonbot |
@carsonbot now please review! |
Hey. Thank you for this PR. Are you a native Czech speaker? Do you know a native that could verify this? |
Yes, I am a native speaker!
|
@Nyholm please do merge this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely. =)
I'll be happy to approve this. A second maintain will review and merge this if they like this as much as I do.
Thank you for your work!
@Nyholm who is the second maintainer? |
And thanks for your approval @Nyholm |
There are a few of us. See https://symfony.com/doc/current/contributing/code/core_team.html |
@fabpot, @nicolas-grekas kindly review this! |
@stof can you merge this, please! |
@Nyholm can you please get it merged? |
src/Symfony/Component/Validator/Resources/translations/validators.cs.xlf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the indentation, thanks
@OskarStark now kindly check! |
I have asked a Czech colleague to review the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, there are some changes in the wording of the Validation Error Messages, which should be implemented to be correct in Czech.
src/Symfony/Component/Validator/Resources/translations/validators.cs.xlf
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Resources/translations/validators.cs.xlf
Outdated
Show resolved
Hide resolved
Hi, i have corrected the pluralization as i forgot it is also different for
1. So we have 1 - znak, 2,3,4 - znaky and 5+ znaků.
Sorry, missed thats special case in the first part.
|
…idators.cs.xlf file
70ff491
to
7ad9db0
Compare
Thank you @shubhalgupta. |