[AssetMapper] Fixing bug where JSCompiler used non-absolute importmap entry path #52368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced over the weekend in #52349.
The
path
key insideimportmap.php
can be a full filesystem path or it can start with./
to indicate a relative path to the root directory. That has been the case for weeks. In #52349, when start using thepath
of an importmap entry to find theMappedAsset
. When doing that, I didn't consider the case wherepath
is a relative path.This PR fixes that and moves the code handling this into
ImportMapConfigReader
so that we're not repeating it in several places.Cheers!