Remove unused code from Process #52399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
|
I don't know this particular part of the code but usually this kind of comparison |
GromNaN
approved these changes
Nov 1, 2023
chapterjason
approved these changes
Nov 1, 2023
| @@ -322,7 +320,7 @@ public function start(callable $callback = null, array $env = []) | |||
|
|
|||
| if ('\\' === \DIRECTORY_SEPARATOR) { | |||
| $commandline = $this->prepareWindowsCommandLine($commandline, $env); | |||
| } elseif (!$this->useFileHandles && $this->isSigchildEnabled()) { | |||
| } elseif ($this->isSigchildEnabled()) { | |||
There was a problem hiding this comment.
Suggested change
| } elseif ($this->isSigchildEnabled()) { | |
| } elseif ('\\' !== \DIRECTORY_SEPARATOR && $this->isSigchildEnabled()) { |
There was a problem hiding this comment.
The elseif will only be considered if if ('\\' === \DIRECTORY_SEPARATOR) (2 lines before) doesn't hit. Basically it will be checked twice but vice versa, as suggested change. 🤔
xabbuh
approved these changes
Nov 1, 2023
nicolas-grekas
force-pushed
the
fix/process-dead-code
branch
from
bca20f0
to
7a5eba2
Compare
|
Thank you @ausi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to work on #43162 (comment) I noticed that the private member
useFileHandlesis not used for anything anymore.It is always set in the constructor to
'\\' === \DIRECTORY_SEPARATORso it basically has a constant value and its only usage is in anelseifafter a check to the very same constant value:if ('\\' === \DIRECTORY_SEPARATOR).Therefore this code does nothing and can be removed.