[Yaml] Fix uid binary parsing #52443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "5.4" but it seems your PR description refers to branch "5.4 and next". Cheers! Carsonbot |
derrabus
approved these changes
Nov 5, 2023
fabpot
approved these changes
Nov 5, 2023
|
Thank you @mRoca. |
This was referenced Nov 10, 2023
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on SF 5.4 & 6.4, a YAML file containing
{ uid: !!binary Ju0Yh+uqSXOagJZFTlUt8g== }cannot be parsed because of apreg_matcherror:Malformed UTF-8 characters, possibly incorrectly encoded.This is because
preg_matchshould not be run over a binary string, but this specific binary string matches the following tests :\is_string($value) && '' !== $value && '&' === $value[0](the string starts with0x26, which is the UTF-8&char).