[Config] Prefixing FileExistenceResource::__toString() to avoid conflict with FileResource
#52502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
FileExistenceResource::__toString() to avoid conflict with FileResource
…ict with FileResource
nicolas-grekas
requested review from
lyrixx,
yceruto,
chalasr,
dunglas,
OskarStark and
xabbuh
as code owners
nicolas-grekas
force-pushed
the
config-cache-clashing-resource-string
branch
from
a88aafd
to
9e8db58
Compare
|
Good catch, thanks @weaverryan. |
|
🚀 |
This was referenced Nov 10, 2023
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This bug causes a pretty critical AssetMapper 6.4 bug. The problem is that both
FileResourceandFileExistenceResourcereturn the same__toString()for the same file:SelfCheckingResourceChecker uses a static cache where the
ResourceInterface::__toString()is the key for that string. That creates the following bug situation:A) Something checks for
FileExistenceResourceforfoo/bar.php. This returns true andSelfCheckingResourceCheckernow hastruefor fresh in its static cacheB) Something else checks for
FileResourceforfoo/bar.php: they are checking to see if the file has been modified. But in instead of calling the actualFileResource::isFresh()method, it uses thetruevalue from the static cache.Cheers!