[DomCrawler] UriResolver support path with columns #52559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is 5.4 not affected by this bug? |
carsonbot
changed the title
…derer) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Updated Lithuanian translations | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix symfony#51948 | License | MIT Missing Lithuanian translations with help from a native speaker. Commits ------- 5938c05 [Validator] updated Lithuanian translation
|
@derrabus From https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/DomCrawler/UriResolver.php I think the but does exist in 5.4. Shall I re-do the a PR targeting 5.4 branch then the patch will be automatically applied upstream ? |
|
Yes, please target 5.4 then. No need to "re-do" the PR, just rebase this one and change the target. |
|
Moved to #52579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving links on pages using weird pagination like:
https://localhost/domain/search/page:5fails due to:makingReturn
false(and not null as expected in the code).This simply ensure the absolute URL is returned only if the SCHEME is found (ie a string is returned by
parse_url).