[Serializer] Fix denormalize constructor arguments #52578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fabbot errors aren't related. |
mtarld
force-pushed
the
fix/serializer-constructor-arguments
branch
from
7be2684
to
1ad0ecc
Compare
nicolas-grekas
approved these changes
Nov 17, 2023
mtarld
force-pushed
the
fix/serializer-constructor-arguments
branch
from
1ad0ecc
to
8f7c7ae
Compare
|
Thank you @mtarld. |
|
@mtarld could you please have a look at the current failures on branch 6.3 for Serializer? I need help to resolve them after the merge up 🙏 |
|
Sorry @nicolas-grekas I'm in a different timezone, so I hadn't time to take of it. But the fix provided by @xabbuh in #52665 is good (it's the one I already had on my local machine) |
This was referenced Nov 26, 2023
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this PR: #51907, objects with partial constructor parameters were wrongly instantiated.
This PR fixes that issue by delegating the properties values assignment, by unsetting normalized data only when the constructor has been called properly.
This might correct #50759 as well.