[Validator] Add additional versions (*_NO_PUBLIC, *_ONLY_PRIV & *_ONLY_RES) in IP address & CIDR constraint
#52658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas rebased, cs fixed, squashed ✅ |
nicolas-grekas
approved these changes
Dec 30, 2023
|
rebased & resolved latest comments, thank you! |
Ninos
changed the title
*_NO_PUBLIC, *_ONLY_PRIV & *_ONLY_RES) in IP address constraint*_NO_PUBLIC, *_ONLY_PRIV & *_ONLY_RES) in IP address & CIDR constraint
javiereguiluz
approved these changes
Jan 25, 2024
derrabus
approved these changes
Jan 25, 2024
fabpot
approved these changes
Feb 3, 2024
…*_ONLY_RES`) in IP address & CIDR constraint
|
Thank you @Ninos. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 7, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [Validator] revert accepting any scalar value | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT This change sneaked into the codebase in #52658. Commits ------- 8d27007 revert accepting any scalar value
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibility to allow no public, only private or only reserved ips.
*_NO_PUBLIC,*_ONLY_PRIV&*_ONLY_RESas possible versions inIpconstraintIpversions inCidrconstraintSee also old MR: #51777