[Translation] [Lokalise] Fix language format on Lokalise Provider #52677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
src/Symfony/Component/Translation/Bridge/Lokalise/LokaliseProvider.php
Outdated
Show resolved
Hide resolved
welcoMattic
force-pushed
the
fix-lokalise-export
branch
from
f3dcca5
to
76c136a
Compare
welcoMattic
force-pushed
the
fix-lokalise-export
branch
from
76c136a
to
7a8897c
Compare
|
Thank you @welcoMattic. |
This was referenced Nov 26, 2023
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lokalise has changed their API a little bit, and ISO languages are formatted with a
-, which is not wrong. But we use it as locale to load the translation with XliffLoader (and other loaders), and it leads to wrong filename likemessages+intl-icu.en-US.xlf.This PR fixes the issue.