Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyInfo] Fixed promoted property type detection for PhpStanExtractor #52684

Merged

Conversation

LastDragon-ru
Copy link
Contributor

@LastDragon-ru LastDragon-ru commented Nov 22, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52682
License MIT

Implementation aligned with actual phpstan behaviour, please see https://phpstan.org/r/8278f037-5a67-4e53-8352-a13585d2eca5

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.3, 6.4, 7.0, 7.1.

Cheers!

Carsonbot

@LastDragon-ru
Copy link
Contributor Author

Rebased to 6.3

@LastDragon-ru
Copy link
Contributor Author

fabbot.io — Some changes should be done to comply with our standards.

Looks like it is not related to PR itself :)

Copy link
Contributor

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me ! Thanks for the fix :)

@nicolas-grekas nicolas-grekas changed the title [PropertyInfo] Fixed promoted property type detection for PhpStanExtractor. [PropertyInfo] Fixed promoted property type detection for PhpStanExtractor Nov 24, 2023
@nicolas-grekas
Copy link
Member

Thank you @LastDragon-ru.

@nicolas-grekas nicolas-grekas merged commit ff3aa75 into symfony:6.3 Nov 24, 2023
3 of 9 checks passed
@LastDragon-ru
Copy link
Contributor Author

You are welcome :)

This was referenced Nov 26, 2023
@fabpot fabpot mentioned this pull request Nov 29, 2023
@nicolas-grekas nicolas-grekas added this to the 6.3 milestone Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants