[HttpKernel] Fix logging deprecations to the "php" channel when channel "deprecation" is not defined

[nicolas-grekas]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #52672
License	MIT

[stof]

This will not log deprecations at all when not using MonologBundle and also won't log them at all when using MonologBundle without explicitly creating a deprecation channel.

This re-introduces the same issue than what was fixed previously. The "bug" you tried to fix is that someone was relying on the previous regression as a feature rather than a bug.

So -1 for me.

[nicolas-grekas]

To me this will log deprecations on the php channel, as wanted

[nicolas-grekas]

I think you missed that deprecations will go on the logger defined as $logger argument when $deprecationLogger is null.

[stof]

If this is indeed the case, why did we have to replace the usage of service('monolog.logger.deprecation')->nullOnInvalid() by a dynamic configuration in the compiler pass in the previous PR ?

[nicolas-grekas]

We did that to wire "logger" by default so that when monolog is not there, we still have a logger for the php notices/deprecations.

[stof]

but you now wire null by default, not logger.

[nicolas-grekas]

Sure, that's the code in DebugHandlersListener that does the trick:

symfony/src/Symfony/Component/HttpKernel/EventListener/DebugHandlersListener.php

Lines 169 to 177 in 1199090

	$defaultLoggerLevels = $this->levels;
	if ($this->deprecationLogger && $levelsDeprecatedOnly) {
	$handler->setDefaultLogger($this->deprecationLogger, $levelsDeprecatedOnly);
	$defaultLoggerLevels = $levelsWithoutDeprecated;
	}
	if ($this->logger && $defaultLoggerLevels) {
	$handler->setDefaultLogger($this->logger, $defaultLoggerLevels);
	}