[VarExporter] Work around php/php-src#12695 for lazy objects, fixing nullsafe-related behavior #52762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Nov 27, 2023
| $this->assertSame(4, $instance->publicReadonly); | ||
| $this->expectException(\BadMethodCallException::class); | ||
| $this->expectExceptionMessage('__isset(public)'); | ||
| isset($instance->public); |
There was a problem hiding this comment.
This test case was asserting a behavior that relied on a work around with buggy side effects.
It's now asserting the correct behavior.
Fixing that incorrect behavior is how I spotted the root issue: other existing test cases that use the nullsafe operator were failing.
This means the work around for php/php-src#12695 implemented here is already covered by tests.
…nullsafe-related behavior
nicolas-grekas
force-pushed
the
ve-fix-nullsafe
branch
from
491eb44
to
b051700
Compare
This was referenced Nov 29, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes another issue discovered with @arnaud-lb while working on lazy-objects.
The root of the issue is described in php/php-src#12695 and this PR implements a fix based on a suggestion by @iluuu1994
Only ghost objects are affected; proxy objects are OK.