[Routing] Restore aliases removal in RouteCollection::remove()
#52845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
fancyweb
force-pushed
the
routing/remove-alias-again
branch
from
7e48053
to
882cbaa
Compare
fancyweb
force-pushed
the
routing/remove-alias-again
branch
from
882cbaa
to
3c6dc17
Compare
stof
approved these changes
Dec 1, 2023
nicolas-grekas
approved these changes
Dec 1, 2023
|
Thank you @fancyweb. |
OskarStark
changed the title
RouteCollection::remove()
This was referenced Dec 1, 2023
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #52831 (comment)
It's still a small behavior change on 5.4, let's see what people think 馃槂