Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Move Router cache directory to kernel.build_dir #52962

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Okhoshi
Copy link
Contributor

@Okhoshi Okhoshi commented Dec 9, 2023

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues none
License MIT

Follow up to #50391, set up Router cache directory to kernel.build_dir instead of kernel.cache_dir by default, and only warm the cache on read-only resources phase.

#SymfonyHackday

@carsonbot carsonbot added this to the 7.1 milestone Dec 9, 2023
@OskarStark OskarStark changed the title [FrameworkBundle] Move Router cache directory to kernel.build_dir [FrameworkBundle] Move Router cache directory to kernel.build_dir Dec 9, 2023
@Okhoshi Okhoshi force-pushed the framework-router-build-dir branch 2 times, most recently from ccb46eb to 4d9a4b0 Compare December 9, 2023 15:14
@fabpot
Copy link
Member

fabpot commented Dec 13, 2023

Thank you @Okhoshi.

@fabpot fabpot merged commit 454d16b into symfony:7.1 Dec 13, 2023
1 check was pending
@Okhoshi Okhoshi deleted the framework-router-build-dir branch December 13, 2023 14:05
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Jan 9, 2024
This PR was merged into the 7.1 branch.

Discussion
----------

[FrameworkBundle] Update `cache_dir` config

Update the documentation on configuration of the FrameworkBundle to reflect the deprecation of `cache_dir` (done in symfony/symfony#52962) and the introduction of `ignore_cache` (from symfony/symfony#53059).

Fixes #19281

Ping `@alexandre`-daubois

Commits
-------

47e0be0 [FrameworkBundle] Update cache_dir config
@fabpot fabpot mentioned this pull request May 2, 2024
nicolas-grekas added a commit that referenced this pull request Jun 28, 2024
This PR was merged into the 7.1 branch.

Discussion
----------

[FrameworkBundle] Fix warming up routes

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Follows #52962 and builds on the semantics of #57553.

Commits
-------

cc918e9 [FrameworkBundle] Fix warming up routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants