[Cache] Fix failing test #53136
Merged
[Cache] Fix failing test #53136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Dec 19, 2023
| @@ -20,8 +20,7 @@ | |||
| * @requires extension couchbase <4.0.0 | |||
| * @requires extension couchbase >=3.0.0 | |||
| * | |||
| * @group integration | |||
| * @group legacy | |||
| * @group integration legacy | |||
There was a problem hiding this comment.
can you please swap them, so that at least we can grep for 'group legacy' and find this one?
alexandre-daubois
force-pushed
the
groups-fix-couchbase
branch
from
a0c6154
to
c5273f3
Compare
alexandre-daubois
force-pushed
the
groups-fix-couchbase
branch
from
c5273f3
to
c1a653e
Compare
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this change didn't work as expected and makes the integration suite fail. I suggest reverting the annotation to one line to fix this.