[PropertyInfo] Restrict access to PhpStanExtractor based on visibility
#53362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jan 2, 2024
src/Symfony/Component/PropertyInfo/Extractor/PhpStanExtractor.php
Outdated
Show resolved
Hide resolved
nikophil
force-pushed
the
property-info/visibility-in-phpstan-extractor
branch
from
fc8e374
to
09bfe6f
Compare
dunglas
reviewed
Jan 4, 2024
src/Symfony/Component/PropertyInfo/Extractor/PhpStanExtractor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PropertyInfo/Extractor/PhpStanExtractor.php
Outdated
Show resolved
Hide resolved
nikophil
force-pushed
the
property-info/visibility-in-phpstan-extractor
branch
from
09bfe6f
to
c970f96
Compare
OskarStark
changed the title
PhpStanExtractor based on visibility
OskarStark
reviewed
Jan 5, 2024
src/Symfony/Component/PropertyInfo/Tests/Fixtures/DummyPropertyAndGetterWithDifferentTypes.php
Outdated
Show resolved
Hide resolved
nikophil
force-pushed
the
property-info/visibility-in-phpstan-extractor
branch
2 times, most recently
from
34d2ad9
to
a03f5ec
Compare
nikophil
force-pushed
the
property-info/visibility-in-phpstan-extractor
branch
from
a03f5ec
to
e3ec55f
Compare
fabpot
approved these changes
Feb 3, 2024
|
Thank you @nikophil. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this small PR gives a bit more control on what
PhpStanExtractorcan see or not, based on the visibility of the property or its accessor.It's pretty unusual, but sometimes, the getter does not return the same type than the property itself, and before this PR, there was actually no way to extract the type returned by the getter.
ReflectionExtractorhas this granularity, but it cannot read complex PhpDoc types.