[Mailer][Notifier] add more #[\SensitiveParameter] attributes
#53399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 4, 2024
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
carsonbot
changed the title
OskarStark
changed the title
#[\SensitiveParameter] attributes
|
We are not consistent how we deal with username (public keys). Sometimes we mark them as sensitive parameters, sometimes we don't. That's why I didn't do anything about them. |
OskarStark
approved these changes
Jan 4, 2024
nicolas-grekas
approved these changes
Jan 4, 2024
xabbuh
force-pushed
the
pr-53230
branch
2 times, most recently
from
6582990
to
a8dae78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.