CS: enable ordered_types.null_adjustment=always_last #53544
Merged
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
changed the title
|
Thank you. Im 👍 |
derrabus
approved these changes
Jan 16, 2024
xabbuh
force-pushed
the
ordered_types_null
branch
from
31deea1
to
67a5d2d
Compare
|
Thank you @keradus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to apply rule to put
nullas last type variant for type declaration.Sf ruleset is already having enabled very same rule for types in phpdoc.
Diff is very minimal, most of codebase already follows it.
If merged, we can adjust official ruleset (PR already prepared by community: PHP-CS-Fixer/PHP-CS-Fixer#7356 )