Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Fix option filenameMaxLength to the File constraint (Image) #53620

Merged
merged 1 commit into from Jan 29, 2024

Conversation

mindaugasvcs
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues ...
License MIT

Recent addition of [filenameMaxLength] option to File constraint added a new error message key to ERROR_NAMES array but that change was not reflected in child class Image, so it just adds missing self::FILENAME_TOO_LONG => 'FILENAME_TOO_LONG' item to ERROR_NAMES array in Image constraint.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Fix option filenameMaxLength to the File constraint (Image) [Validator] Fix option filenameMaxLength to the File constraint (Image) Jan 23, 2024
@nicolas-grekas
Copy link
Member

Thank you @mindaugasvcs.

@nicolas-grekas nicolas-grekas merged commit a318801 into symfony:6.4 Jan 29, 2024
8 of 9 checks passed
This was referenced Jan 31, 2024
@mindaugasvcs
Copy link
Contributor Author

mindaugasvcs commented Feb 1, 2024

I have also created Symfony compatible Video validator but it relies on external command-line tool ffprobe, it could be easily expanded to add Audio validator. Do you think Symfony needs such validators with external dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants