Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mailer] Add timestamp to SMTP debug log #53706

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

bytestream
Copy link
Contributor

@bytestream bytestream commented Jan 31, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

When debugging #53647, the lack of a timestamp made it difficult to understand why the RSET was happening before a response had been received. The timestamps gave a clue towards the problem. The timestamps also help show slow connections which you're otherwise not aware of.

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 7.1 milestone Jan 31, 2024
@bytestream bytestream changed the base branch from 7.1 to 6.4 January 31, 2024 14:41
@nicolas-grekas nicolas-grekas modified the milestones: 7.1, 6.4 Feb 1, 2024
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should target 7.1 as it's not a bugfix.

@derrabus derrabus modified the milestones: 7.1, 6.4 Feb 1, 2024
@bytestream bytestream changed the base branch from 6.4 to 7.1 February 1, 2024 10:49
@fabpot
Copy link
Member

fabpot commented Feb 4, 2024

Thank you @bytestream.

@fabpot fabpot merged commit 4b4962a into symfony:7.1 Feb 4, 2024
6 of 9 checks passed
@bytestream bytestream deleted the mailer-log branch February 4, 2024 10:47
@fabpot fabpot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants