Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoctrineBridge] forward-compatibility with field mappings in Doctrine ORM 4 #53754

Merged
merged 1 commit into from Feb 4, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 4, 2024

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

see doctrine/orm#11211

@fabpot
Copy link
Member

fabpot commented Feb 4, 2024

Do we need to do it on 5.4?

@derrabus
Copy link
Member

derrabus commented Feb 4, 2024

Do we need to do it on 5.4?

Yes.

@xabbuh xabbuh changed the base branch from 6.4 to 5.4 February 4, 2024 14:43
@xabbuh
Copy link
Member Author

xabbuh commented Feb 4, 2024

rebased on 5.4

@fabpot fabpot modified the milestones: 6.4, 5.4 Feb 4, 2024
@fabpot
Copy link
Member

fabpot commented Feb 4, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit ff5dc26 into symfony:5.4 Feb 4, 2024
6 of 9 checks passed
@xabbuh xabbuh deleted the doctrine-orm-1211 branch February 4, 2024 16:57
xabbuh added a commit that referenced this pull request Feb 4, 2024
This PR was merged into the 5.4 branch.

Discussion
----------

[DoctrineBridge] fix syntax errors on PHP 7

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

I missed this when rebasing #53754 on the `5.4` branch

Commits
-------

42d6424 fix syntax errors on PHP 7
This was referenced Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants