Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] Fix configuring CliDumper with SYMFONY_IDE env var #53842

Merged
merged 1 commit into from Feb 8, 2024

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

When using dump() in a plain PHP script, SYMFONY_IDE is currently ignored. This fixes it when FileLinkFormatter is available.

@Nyholm
Copy link
Member

Nyholm commented Feb 7, 2024

Would you mind adding a tests too?

@nicolas-grekas nicolas-grekas force-pushed the vd-formatter branch 2 times, most recently from 2248a8c to b603892 Compare February 8, 2024 14:41
@nicolas-grekas
Copy link
Member Author

Would you mind adding a tests too?

done!

@nicolas-grekas nicolas-grekas merged commit 22efc29 into symfony:6.4 Feb 8, 2024
5 of 9 checks passed
@nicolas-grekas nicolas-grekas deleted the vd-formatter branch February 20, 2024 16:27
This was referenced Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants