[PropertyAccess] Fixes getValue() on an unitialized object property on a lazy ghost #53891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Feb 12, 2024
nicolas-grekas
force-pushed
the
fix-propertyaccess-getvalue-lazyghost
branch
from
19fda35
to
cae256b
Compare
|
Thank you @priyadi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a lazy ghost that has an uninitialized property that should contain an object, attempting to
$propertyAccessor->getValue()on it will previously throwError, not the expectedUninitializedPropertyException. This PR fixes the problem.