[FrameworkBundle] Check if the _route attribute exists on the request

[xvilo]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

The _route attribute does not always exist in some codebases when RedirectController is used. $request->attributes->get() will default to null if the value does not exist, yielding a PHP error as the return type is set to string.

Symfony\Bundle\FrameworkBundle\DataCollector\RouterDataCollector::guessRoute(): Return value must be of type string, null returned

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[nicolas-grekas]

Thank you @xvilo.