Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge] foundation 5 layout: use form_label_content block for checkbox and radio labels #53926

Merged
merged 1 commit into from Feb 15, 2024

Conversation

wetternest
Copy link
Contributor

…dio labels

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #53925
License MIT

[Twig Bridge] Foundation5 Form Layout

use the block form_label_content to display the label content of checkboxes and radios in order to support the label_html flag

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title foundation 5 layout: use form_label_content block for checkbox and ra… [TwigBridge] foundation 5 layout: use form_label_content block for checkbox and ra… Feb 14, 2024
@nicolas-grekas nicolas-grekas changed the title [TwigBridge] foundation 5 layout: use form_label_content block for checkbox and ra… [TwigBridge] foundation 5 layout: use form_label_content block for checkbox and radio labels Feb 15, 2024
@nicolas-grekas
Copy link
Member

Thank you @wetternest.

@nicolas-grekas nicolas-grekas merged commit e81547b into symfony:6.4 Feb 15, 2024
4 of 9 checks passed
This was referenced Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants