[FrameworkBundle] Fix registration of the bundle path to translation

[FlyingDR]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

31d7a09 had a small issue resulting in a lack of proper registration of path to translation resources in installed bundles.

The issue is caused by the incomplete update of the code where the newly added $transPaths variable was not updated in all code branches (1, 2, 3, but not 4)

The issue can be reproduced and tested like this:

composer create-project symfony/skeleton test
cd test
composer require easycorp/easyadmin-bundle
php bin/console debug:translation en --domain EasyAdminBundle

It will result in unexpected:

[WARNING] No defined or extracted messages for locale "en" and domain "EasyAdminBundle"

After applying the fix, clearing the cache and running the same command list of messages will be returned properly.

[nicolas-grekas]

/cc @yceruto 🙏

[stof]

why do we use 2 variables that must contain the same content ? Wouldn't it be simpler to use a single variable (or maybe to do $transPaths = $dirs when reaching the end of the common initialization instead ?)

[yceruto]

It can be optimized for sure.

[fabpot]

Thank you @FlyingDR.