Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lock] Make NoLock implement the SharedLockInterface #54084

Merged
merged 1 commit into from
Feb 27, 2024
Merged

[Lock] Make NoLock implement the SharedLockInterface #54084

merged 1 commit into from
Feb 27, 2024

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Feb 27, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #53713
License MIT

This PR updates the Symfony\Component\Lock\NoLock stub to implement Symfony\Component\Lock\SharedLockInterface and returns it to being compatible with the Symfony\Component\Lock\LockFactory return types.

@carsonbot carsonbot added this to the 7.1 milestone Feb 27, 2024
@nicolas-grekas
Copy link
Member

Thank you @mbabker.

@nicolas-grekas nicolas-grekas merged commit 9e810de into symfony:7.1 Feb 27, 2024
7 of 9 checks passed
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 27, 2024
Closed
@mbabker mbabker deleted the 7.1-no-lock-as-shared-lock branch February 27, 2024 16:03
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

@derrabus derrabus derrabus approved these changes

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

Assignees
No one assigned
Labels
Feature Lock Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

[Lock] Narrowed return type of LockFactory makes mocks with NoLock incompatible
5 participants
@mbabker @nicolas-grekas @stof @derrabus @carsonbot