[HttpKernel] Improve error reporting when requiring the wrong Request class #54107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyachase
commented
Feb 29, 2024
|
Not sure what to do with failed checks - errors seem irrelevant to my changes. Please help. |
|
Please find a meaningful title for your PR. We use PR titles to compose the change log.
If you didn't cause them, ignore them. |
ilyachase
changed the title
Done.
👌 |
stof
reviewed
Feb 29, 2024
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/RequestValueResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/RequestValueResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Exception/FailedToResolveValueException.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Exception/NearMissValueResolverException.php
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Tests/Controller/ArgumentResolverTest.php
Outdated
Show resolved
Hide resolved
stloyd
reviewed
Feb 29, 2024
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver.php
Outdated
Show resolved
Hide resolved
|
@stof @nicolas-grekas hey folks, let's get this PR moving? 🙂 I believe I addressed everything |
nicolas-grekas
approved these changes
Mar 5, 2024
stloyd
approved these changes
Mar 6, 2024
fabpot
approved these changes
Mar 9, 2024
|
Thank you @ilyachase. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NearMissValueResolverExceptionis introduced to be used inside any implementer ofValueResolverInterfaceto specify why exactly a value cannot be resolved. It's later used inArgumentResolverto compute an exception if no value resolvers can resolve the value.