[Console] Add a way to use custom lock factory in lockableTrait

[VincentLanglet]

Q	A
Branch?	7.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	Fix #...
License	MIT

The LockableTrait only use SemaphoreStore or FlockStore, but currently we cannot use MemcachedStore or RedisStore.

When using a custom LockFactory everywhere in the codebase, it would be useful to chose if the commande need a server-related store or not.

I'm not sure if I have a way to provide autowire to the setLockFactory method without introducing a BC break for people who rely on the fact that the LockableTrait use a different LockFactory than the one configured the framework.lock dsn.

[carsonbot]

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

[94noni]

it could be a valuable addition indeed,
but this reminds me a discussion of mine (other account)

[VincentLanglet]

it could be a valuable addition indeed,

but this reminds me a discussion of mine (other account)

I also saw #53923.

I currently find the LockableTrait really confusing because when using it (without reading the code inside) you could expect that the trait use the default configured lock factory instead of creating a new one.

I was trying to improve the situation...

[94noni]

Yes and you do good i think but may it will leverage discussion
Perhaps create another trait and name it specifically ?
and yes i’ve also seen the issue discussion and the doc and/or the class can be improved to give more context to the dev

[derrabus]

Tests? 🙃

[VincentLanglet]

Tests? 🙃

Indeed, I added some now @derrabus

[nicolas-grekas]

Thank you @VincentLanglet.