[Mailer] Fix sendmail transport not handling failure #54239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboks
force-pushed
the
sendmail-handle-failure
branch
from
3dee58c
to
227d166
Compare
nicolas-grekas
approved these changes
Mar 12, 2024
src/Symfony/Component/Mailer/Transport/Smtp/Stream/ProcessStream.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
sendmail-handle-failure
branch
from
b6638dd
to
684e7af
Compare
|
Thank you @aboks. |
This was referenced Apr 2, 2024
Merged
Merged
Merged
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that the Mailer component
SendmailTransportdoes not detect all failures. TheProcessStreamchecks stderr when the process is started, but it does not check the exit code and output afterwards. This could lead to silent failures.We found this out due to having
sendmail_path = "/usr/bin/msmtp -t --read-envelope-from"inphp.ini, butmsmtpdoes not like--read-envelope-fromin combination with the-foption added by Symfony Mailer. In this case,msmtpfails with exit status 64 and a message on stdout (rather than stderr). The latter is the reason why I also added the stdout output to the error message (along with the stderr output).Feel free to modify this PR to bring it more in line with existing standards and conventions. The most important part to me is that a failure like this is detected and the mailer does not silently fail.