[Messenger] Make Doctrine connection ignore unrelated tables on setup #54392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Apr 8, 2024
xabbuh
approved these changes
Apr 8, 2024
fabpot
approved these changes
Apr 8, 2024
|
Thank you @MatTheCat. |
This was referenced Apr 29, 2024
Merged
Merged
Merged
|
In our case this PR breaks on postgres if a newer version of doctrine dbal is used since the filter receives also This issue is also already fixed by @xabbuh s. So for others searching this issue, we only need to wait for the next v6.4.8 release. |
|
For reference: #54775 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introspecting the whole database can cause issues like Doctrine crashing on unknown column types. This PR updates the schema assets filter (added by #31625) to only consider the messages table, as it is the only one a connection setup needs to care about.