[Validator] Add a requireTld option to Url constraint
#54408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Mar 27, 2024
src/Symfony/Component/Validator/Tests/Constraints/UrlValidatorTest.php
Outdated
Show resolved
Hide resolved
|
we need an entry in the Validator component's changelog file |
|
I've added the changelog entry. Thanks! |
xabbuh
approved these changes
Mar 27, 2024
smnandre
reviewed
Mar 30, 2024
smnandre
reviewed
Mar 30, 2024
javiereguiluz
added
the
❄️ Feature Freeze
OskarStark
changed the title
requireTld option to Url constraint
fabpot
approved these changes
Apr 5, 2024
|
Thank you @javiereguiluz. |
wouterj
reviewed
Apr 6, 2024
| ) { | ||
| parent::__construct($options, $groups, $payload); | ||
|
|
||
| $this->message = $message ?? $this->message; | ||
| $this->protocols = $protocols ?? $this->protocols; | ||
| $this->relativeProtocol = $relativeProtocol ?? $this->relativeProtocol; | ||
| $this->normalizer = $normalizer ?? $this->normalizer; | ||
| $this->requireTld = $requireTld ?? $this->requireTld; |
There was a problem hiding this comment.
In the issue, we discussed deprecating not setting this, so we can change the default to true (which is in sync with the Hostname constraint's requireTld option).
Do we still want to do this?
If we don't, I would say we change the default of the parameter to false instead (I see no point making it nullable?)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the last part of #50871 following the suggestions from Wouter and Christian in
#50871 (comment)