[Clock] Add a polyfill for DateTimeImmutable::createFromTimestamp() #54442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
feature/create-from-timestamp
branch
from
dbf7abe
to
27a7fbb
Compare
|
I ignored fabbot's proposed exception message formatting because I'd like to stay close to the exception message generated by the upstream implementation. |
derrabus
force-pushed
the
feature/create-from-timestamp
branch
from
27a7fbb
to
7cf2d71
Compare
xabbuh
reviewed
Apr 1, 2024
derrabus
force-pushed
the
feature/create-from-timestamp
branch
from
7cf2d71
to
e2e7ffa
Compare
javiereguiluz
approved these changes
Apr 2, 2024
javiereguiluz
added
the
❄️ Feature Freeze
derrabus
force-pushed
the
feature/create-from-timestamp
branch
3 times, most recently
from
7ca0fbd
to
cc1144d
Compare
derrabus
force-pushed
the
feature/create-from-timestamp
branch
from
cc1144d
to
9e48e0d
Compare
|
Ready |
|
Thank you @derrabus. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new
createFromTimestamp()method introduced in php/php-src#12413 to ourDatePointclass. It comes with a polyfill implementation for PHP 8.2/8.3.