Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emoji] Add the "text" locale #54470

Merged
merged 1 commit into from
Apr 5, 2024
Merged

[Emoji] Add the "text" locale #54470

merged 1 commit into from
Apr 5, 2024

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Apr 3, 2024 •
edited
Loading

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT
  • Adding the "text" locale, which is a merge from slack+github+gitlab maps
  • Fixes the gitlab maps which were missing aliases and combined emojis
  • Ordering the github/gitlab/slack maps so that we can compare them
  • Fixing a typo
  • Removing a needless check that prevents listing '🙂‍↔' => 'head shaking horizontally',
  • Simplifying the build script a bit

@carsonbot carsonbot added this to the 7.1 milestone Apr 3, 2024
lyrixx
lyrixx reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor question, otherwise 👍🏼

src/Symfony/Component/Emoji/Resources/bin/build.php Show resolved Hide resolved
@nicolas-grekas nicolas-grekas force-pushed the emoji-fix branch 3 times, most recently from d195dcd to cb69d3f Compare April 3, 2024 11:47
@nicolas-grekas nicolas-grekas force-pushed the emoji-fix branch 2 times, most recently from 903606c to 2581839 Compare April 4, 2024 08:25
@nicolas-grekas nicolas-grekas changed the title [Emoji] More ordering and minor fixes [Emoji] Add the "text" locale Apr 4, 2024
@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Apr 4, 2024 •
edited
Loading

PR updated to add a new "text" locale, which uses a map resulting from merging slack+github+gitlab maps.
This also fixes the gitlab maps, which were missing combined emojis and aliases.

@lyrixx
Copy link
Member

lyrixx commented Apr 4, 2024

PR updated to add a new "text" locale, which uses a map resulting from merging slack+github+gitlab maps.

love it!

@nicolas-grekas nicolas-grekas added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Apr 4, 2024
@nicolas-grekas nicolas-grekas mentioned this pull request Apr 4, 2024
Merged
lyrixx
lyrixx approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Thanks

@fabpot
Copy link
Member

fabpot commented Apr 5, 2024

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 220b5bc into symfony:7.1 Apr 5, 2024
9 of 11 checks passed
@fabpot fabpot mentioned this pull request Apr 5, 2024
Closed
@nicolas-grekas nicolas-grekas deleted the emoji-fix branch April 5, 2024 09:46
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@smnandre smnandre smnandre left review comments

@fabpot fabpot fabpot approved these changes

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
Emoji ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nicolas-grekas @lyrixx @fabpot @stof @smnandre @carsonbot