Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HtmlSanitizer] Ignore Processing Instructions #54513

Merged

Conversation

smnandre
Copy link
Contributor

@smnandre smnandre commented Apr 6, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #54492
License MIT

Ignore Processing Instructions (as comments) to avoid mixing them with standard DOM nodes (see #54492)

(targetting 6.4 as the component was released in 6.1))

Copy link

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a part of Symfony, but this seems right to me, thanks for the patch!

@fabpot
Copy link
Member

fabpot commented Apr 8, 2024

Thank you @smnandre.

@fabpot fabpot merged commit 00ba3ad into symfony:6.4 Apr 8, 2024
7 of 10 checks passed
This was referenced Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants