[process] provide a restart method.

[boombatower]

Pull request for issue #5452.

Another possibility would be to allow for either run() or start() scenarios, but I am not sure that is terribly useful since restart() with a new process lends itself to restarting longer running services when they crash and you want the old process so you can inspect the logs and what not.

Otherwise, something like this might work, but doesn't allow for run() to return status code. Someone can get around that by getting manually on returned process.

<?php
public function restart($method = 'start', $callback = null)
{
    if ($this->isRunning()) {
        throw new \RuntimeException('Process is already running');
    }

    if ($method != 'start' && $method != 'run') {
        throw new \RuntimeException('Method must be start or run');
    }

    $process = clone $this;
    $process->$method();
    return $process;
}

[pborreli]

can you add some tests please ?

[stloyd]

unset() accepts multi values.

[boombatower]

Yes, but is that preferred? and do you want them on one line or wrapped for each variable.

<?php
unset($var1, $var2);
unset(
  $var1,
  $var2
);

Or some variation.

[stof]

you should not unset the properties of the class but only reset the values in the object only

[boombatower]

I am not sure what you mean. Since the default state is non-set, unset() returns them to that state. Anything else like setting equal to null would not be equivalent.

[stof]

unset($this->stdout) does not unset the value of the property. It unsets the property itself. Try to do a property_exists call after that.

If you try reading one of these properties before writing in it again, you will have an E_STRICT error. And if you write first, you will end with a public properties as properties added on the fly are public.

[boombatower]

That's good to know and seems somewhat non-intuitive. So what is the proper solution then to "reset the value" setting to null is the closest it seems.

[stof]

it is the way to do it.