Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ldap] Improve error reporting during LDAP bind #54604

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

RoSk0
Copy link
Contributor

@RoSk0 RoSk0 commented Apr 15, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

In some rare edge-case where there are issue binding to the LDAP server, for example where the error code doesn't match known error codes in \Symfony\Component\Ldap\Adapter\ExtLdap\Connection::bind() it would be very useful to get any additional information available.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@symfony symfony deleted a comment from carsonbot Apr 15, 2024
@carsonbot carsonbot changed the title Improve error reporting during LDAP bind [Ldap] Improve error reporting during LDAP bind Apr 15, 2024
@fabpot
Copy link
Member

fabpot commented Apr 17, 2024

Thank you @RoSk0.

@fabpot fabpot merged commit 1d847b4 into symfony:7.1 Apr 17, 2024
5 of 10 checks passed
@fabpot fabpot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants