Fixed the phpdoc in the DependencyInjection component #5467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis failure is unrelated. It is all about some intl failures. |
| @@ -93,8 +93,6 @@ private function parseParameters(SimpleXMLElement $xml, $file) | |||
| * | |||
| * @param SimpleXMLElement $xml | |||
| * @param string $file | |||
| * | |||
| * @return void | |||
There was a problem hiding this comment.
Are you sure?
if (false === $imports = $xml->xpath('//container:imports/container:import')) {
return;
}
There was a problem hiding this comment.
It does not return anything. And Symfony does not use @return void in such cases: http://symfony.com/doc/current/contributing/code/standards.html#documentation
|
Reviewed-by: Michal Piotrowski michal@eventhorizon.pl |
|
👍 |
fabpot
added a commit
that referenced
this pull request
Sep 8, 2012
Commits ------- 05f7f78 Fixed the phpdoc in the DependencyInjection component Discussion ---------- Fixed the phpdoc in the DependencyInjection component I was sick of having a warning in my IDE each time I used DefinitionDecorator because of an invalid phpdoc in the constructor, so I took some time and fixed it in the whole DI component. --------------------------------------------------------------------------- by stof at 2012-09-07T23:09:04Z The travis failure is unrelated. It is all about some intl failures. --------------------------------------------------------------------------- by eventhorizonpl at 2012-09-07T23:37:04Z Reviewed-by: Michal Piotrowski <michal@eventhorizon.pl> --------------------------------------------------------------------------- by pborreli at 2012-09-08T01:42:26Z :+1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was sick of having a warning in my IDE each time I used DefinitionDecorator because of an invalid phpdoc in the constructor, so I took some time and fixed it in the whole DI component.