New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of first arg of uniqid #54786

Closed

fabpot wants to merge 1 commit into symfony:5.4 from fabpot:uniqid-type-fix

Member

fabpot commented Apr 30, 2024

Q	A
Branch?	5.4
Bug fix?	no
New feature?	no
Deprecations?	no
Issues	n/a
License	MIT


          Fix type of first arg of uniqid

b4ec831

carsonbot added the Status: Needs Review label

carsonbot added this to the 5.4 milestone

xabbuh approved these changes

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Member

nicolas-grekas commented Apr 30, 2024

👎 casting is dangerous and not needed (we don't use strict types and SA tools are a bit too rigid)

fabpot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment