Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeInfo] end/current instead of array_pop #54790

Merged
merged 1 commit into from May 1, 2024
Merged

[TypeInfo] end/current instead of array_pop #54790

merged 1 commit into from May 1, 2024

Conversation

soyuka
Copy link
Contributor

@soyuka soyuka commented Apr 30, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
License MIT

We don't need to modify the array here, I think it's a micro-optimization to use end and current instead of changing an array size.

@carsonbot carsonbot added this to the 7.1 milestone Apr 30, 2024
@fabpot
Copy link
Member

fabpot commented May 1, 2024

Thank you @soyuka.

@fabpot fabpot merged commit 1119ab6 into symfony:7.1 May 1, 2024
4 of 7 checks passed
@soyuka soyuka deleted the type-info-micro-opti branch May 2, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas dunglas approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

@mtarld mtarld mtarld approved these changes

Assignees
No one assigned
Labels
Status: Reviewed TypeInfo
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@soyuka @fabpot @dunglas @nicolas-grekas @OskarStark @xabbuh @mtarld @carsonbot